Feature/656 add integration tests #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add unit tests to expand coverage - update most dependencies
…nto feature/656-als-new-unit-tests
- upgrade circleCI runner to 2.1 to get docker-compose working
…nto feature/656-add-integration-tests
lewisdaly
commented
Oct 8, 2019
lewisdaly
commented
Oct 8, 2019
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "account-lookup-service", | |||
| "description": "Account Lookup Service is used to validate Party and Participant lookups", | |||
| "version": "8.2.1", | |||
| "version": "8.2.3", | |||
There was a problem hiding this comment.
Needed an extra bump because CircleCI was restoring an invalid cache for 8.2.2
oderayi
reviewed
Oct 8, 2019
…s-tech/account-lookup-service into feature/656-add-integration-tests
|
@rmothilal tidied up the circle ci config as requested. Its actually a lot cleaner since we can specify the working directory within the executor section |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mysqlinstance in the docker container for thecentral-ledgerservice, which is a dependency for the account-lookup-service. I ended up putting themysql-clhost port on3307, which is the opposite to how it was.