-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: moved get_config_templates, get_modules_cbm_config, get_pr… #181
chore: moved get_config_templates, get_modules_cbm_config, get_pr… #181
Conversation
…ovider_config to preprocess.py file Signed-off-by: khanjasir90 <[email protected]>
@Namyalg could u review it once ! |
I will take a look @khanjasir90, have you run the simulation with the refactored structure? |
@Namyalg no! since it was just a refractor change |
I suggest you test run the simulation and share what you find |
@Namyalg ! after running the simulation I got the following response: |
Yes, that's right |
Ok cool will do it rn! |
@Namyalg curl to /gcmb/upload throughs the following error |
Have you unzipped the contents of |
@Namyalg oh my bad! i was'nt executing the commands for that directory.So sorry for disturbing you for small things. |
Looks good. |
Signed-off-by: khanjasir90 <[email protected]>
@Namyalg linted the code using black. |
Awesome, thanks a lot @khanjasir90 |
…oja-global#181) * refactor: moved get_config_templates, get_modules_cbm_config, get_provider_config to preprocess.py file Signed-off-by: khanjasir90 <[email protected]> * app.py and preprocess.py linted Signed-off-by: khanjasir90 <[email protected]> Signed-off-by: khanjasir90 <[email protected]> Signed-off-by: Freeman <[email protected]>
…oja-global#181) * refactor: moved get_config_templates, get_modules_cbm_config, get_provider_config to preprocess.py file Signed-off-by: khanjasir90 <[email protected]> * app.py and preprocess.py linted Signed-off-by: khanjasir90 <[email protected]> Signed-off-by: khanjasir90 <[email protected]> Signed-off-by: Freeman <[email protected]>
…oja-global#181) * refactor: moved get_config_templates, get_modules_cbm_config, get_provider_config to preprocess.py file Signed-off-by: khanjasir90 <[email protected]> * app.py and preprocess.py linted Signed-off-by: khanjasir90 <[email protected]> Signed-off-by: khanjasir90 <[email protected]> Signed-off-by: Freeman <[email protected]>
…ovider_config to preprocess.py file
Signed-off-by: khanjasir90 [email protected]
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
refractor
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Additional Context (Please include any Screenshots/gifs if relevant)
...
Checklist: