Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: moved get_config_templates, get_modules_cbm_config, get_pr… #181

Conversation

khanjasir90
Copy link
Contributor

…ovider_config to preprocess.py file

Signed-off-by: khanjasir90 [email protected]

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

refractor
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Additional Context (Please include any Screenshots/gifs if relevant)

...

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have tagged the reviewers in a comment below incase my pull request is ready for a review
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

…ovider_config to preprocess.py file

Signed-off-by: khanjasir90 <[email protected]>
@khanjasir90
Copy link
Contributor Author

@Namyalg could u review it once !

@Namyalg
Copy link
Member

Namyalg commented Sep 9, 2022

I will take a look

@khanjasir90, have you run the simulation with the refactored structure?

@khanjasir90
Copy link
Contributor Author

@Namyalg no! since it was just a refractor change

@Namyalg
Copy link
Member

Namyalg commented Sep 9, 2022

I suggest you test run the simulation and share what you find

@khanjasir90
Copy link
Contributor Author

@Namyalg ! after running the simulation I got the following response:
command exec : curl -d "title=run4" -X POST http://localhost:8080/gcbm/new
image

@Namyalg
Copy link
Member

Namyalg commented Sep 9, 2022

Yes, that's right
Execute the endpoints, /gcbm/upload and /gcbm/dynamic as mentioned in the curl.md file
If they dont throw any error, it means the PR is good to go

@khanjasir90
Copy link
Contributor Author

Ok cool will do it rn!

@khanjasir90
Copy link
Contributor Author

@Namyalg curl to /gcmb/upload throughs the following error
image

@Namyalg
Copy link
Member

Namyalg commented Sep 10, 2022

Have you unzipped the contents of GCBM_New_Demo_Run and are executing the command from within that directory?

@khanjasir90
Copy link
Contributor Author

@Namyalg oh my bad! i was'nt executing the commands for that directory.So sorry for disturbing you for small things.
After executing those command from that directory it works fine.
I have attached the ss of the same
image

@Namyalg
Copy link
Member

Namyalg commented Sep 10, 2022

Looks good.
Before the PR is merged, can you ensure the code is linted correctly using black https://github.com/psf/black

@Namyalg Namyalg changed the title refractor: moved get_config_templates, get_modules_cbm_config, get_pr… refactor: moved get_config_templates, get_modules_cbm_config, get_pr… Sep 10, 2022
@Namyalg Namyalg changed the title refactor: moved get_config_templates, get_modules_cbm_config, get_pr… chore: moved get_config_templates, get_modules_cbm_config, get_pr… Sep 10, 2022
@khanjasir90
Copy link
Contributor Author

@Namyalg linted the code using black.
image

@Namyalg
Copy link
Member

Namyalg commented Sep 10, 2022

Awesome, thanks a lot @khanjasir90

@Namyalg Namyalg merged commit b97dd30 into moja-global:master Sep 10, 2022
Freeman-kuch pushed a commit to Freeman-kuch/FLINT.Cloud that referenced this pull request Oct 20, 2022
…oja-global#181)

* refactor: moved get_config_templates, get_modules_cbm_config, get_provider_config to preprocess.py file

Signed-off-by: khanjasir90 <[email protected]>

* app.py and preprocess.py linted

Signed-off-by: khanjasir90 <[email protected]>

Signed-off-by: khanjasir90 <[email protected]>
Signed-off-by: Freeman <[email protected]>
Freeman-kuch pushed a commit to Freeman-kuch/FLINT.Cloud that referenced this pull request Oct 20, 2022
…oja-global#181)

* refactor: moved get_config_templates, get_modules_cbm_config, get_provider_config to preprocess.py file

Signed-off-by: khanjasir90 <[email protected]>

* app.py and preprocess.py linted

Signed-off-by: khanjasir90 <[email protected]>

Signed-off-by: khanjasir90 <[email protected]>
Signed-off-by: Freeman <[email protected]>
Freeman-kuch pushed a commit to Freeman-kuch/FLINT.Cloud that referenced this pull request Oct 28, 2022
…oja-global#181)

* refactor: moved get_config_templates, get_modules_cbm_config, get_provider_config to preprocess.py file

Signed-off-by: khanjasir90 <[email protected]>

* app.py and preprocess.py linted

Signed-off-by: khanjasir90 <[email protected]>

Signed-off-by: khanjasir90 <[email protected]>
Signed-off-by: Freeman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants