Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue with reaonly filesystems #2357

Merged

Conversation

RossHammer
Copy link
Contributor

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

closes #2356

Give a brief description for the solution you have provided

I have moved creating the data cache to be when the data is requested rather than on import. This will allow anyone using this on a readonly filesystem to be able to import an use the package.

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks or tutorial (if appropriate)
  • Added tests (if appropriate)
  • Updated CHANGELOG.md (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter
  • Run the spellchecker (if appropriate)

@RobinL
Copy link
Member

RobinL commented Aug 27, 2024

Thanks! Looks reasonable to me, but Andy was the original author of this code will get his opinion first.. Might also solve #2341 @ADBond look ok to you?

@ADBond
Copy link
Contributor

ADBond commented Sep 2, 2024

Yep, this looks great, thanks!

@ADBond ADBond merged commit 21d316c into moj-analytical-services:master Sep 2, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues in a readonly filesystem
4 participants