Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Early return fixes #2332 #2342

Merged
merged 1 commit into from
Aug 17, 2024
Merged

Conversation

bnm3k
Copy link
Contributor

@bnm3k bnm3k commented Aug 16, 2024

When register_udfs is set to False, add early return to avoid accessing unbounded local variables

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Is your Pull Request linked to an existing Issue or Pull Request?

Closes #2332

Give a brief description for the solution you have provided

If register_udfs is set to False, returns early rather than attempt to register un-imported fuzzy match functions

PR Checklist

  • Added documentation for changes
  • Added feature to example notebooks or tutorial (if appropriate)
  • Added tests (if appropriate)
  • Updated CHANGELOG.md (if appropriate)
  • Made changes based off the latest version of Splink
  • Run the linter
  • Run the spellchecker (if appropriate)

When register_udfs is set to False, add early return to avoid accessing
unbounded local variables
Copy link
Member

@RobinL RobinL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@RobinL RobinL merged commit 1383cff into moj-analytical-services:master Aug 17, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't create SQLiteAPI with register_udfs=False
2 participants