Merge pull request #1996 from moj-analytical-services/bug/older-sqlgl…

…ot-compatibility sqlglot.parse_one - use read keyword argument
moj-analytical-services · Feb 23, 2024 · dd2df28 · dd2df28
2 parents e978948 + 6997ff5
commit dd2df28
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+### Fixed
+
+- Bug that prevented `sqlglot <= 17.0.0` from working properly ([#1996](https://github.com/moj-analytical-services/splink/pull/1996))
+
 ## [3.9.12] - 2024-01-30
 
 ### Fixed

diff --git a/splink/input_column.py b/splink/input_column.py
@@ -106,7 +106,7 @@ def add_quotes_to_column_name(input_str, q_s, q_e):
 
         # If the raw string parses to a valid signature, use it
         try:
-            tree = sqlglot.parse_one(input_str, dialect=sqlglot_dialect)
+            tree = sqlglot.parse_one(input_str, read=sqlglot_dialect)
         except (sqlglot.ParseError, sqlglot.TokenError):
             pass
         else:
@@ -123,7 +123,7 @@ def add_quotes_to_column_name(input_str, q_s, q_e):
         q_s, q_e = _get_dialect_quotes(sqlglot_dialect)
         input_str = add_quotes_to_column_name(input_str, q_s, q_e)
         try:
-            tree = sqlglot.parse_one(input_str, dialect=sqlglot_dialect)
+            tree = sqlglot.parse_one(input_str, read=sqlglot_dialect)
         except (sqlglot.ParseError, sqlglot.TokenError):
             pass
         else: