DATA-336 add security changes to the BasicKubernetesPodOperator #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has a corresponding PR in data-engineering-airflow, in which there is added the new default pod template file for the BasicKubernetesOperator. The order of precedence for these settings means users specifying their own image files will have precedence over the image specified here. This should not be merged until it's sister PR has first been merged, to ensure the file will exist in all envs.
This is a minor change, as we already force users to upload dags that have precedence over all settings in this template - however it is still best practice to specify a template of minimal permissions.