Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to type negative numbers in smpl mode (#168) #169

Merged
merged 3 commits into from
Aug 9, 2018
Merged

Add ability to type negative numbers in smpl mode (#168) #169

merged 3 commits into from
Aug 9, 2018

Conversation

titusjaka
Copy link
Contributor

bound with #168

@titusjaka titusjaka self-assigned this Aug 2, 2018
@sashasushko
Copy link

This component also used in trigger edit form for TTL. Can TLL be negative number? If not, need validation for this case.

Also, if you modify component behaviour, add story to Storybook.

@titusjaka
Copy link
Contributor Author

Yep, you are right. TTL should never be negative.

@sashasushko
Copy link

Jim Carrey

Who will fix? You? Me? You? Me?

@titusjaka
Copy link
Contributor Author

You are more competent 😉

sashasushko
sashasushko approved these changes Aug 8, 2018
View reviewed changes
Copy link

@sashasushko sashasushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@titusjaka
Copy link
Contributor Author

Cool bro

@titusjaka titusjaka merged commit 13bd127 into master Aug 9, 2018
@titusjaka titusjaka deleted the hotfix/negative-numbers-input branch August 9, 2018 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sashasushko sashasushko sashasushko approved these changes

Assignees

@titusjaka titusjaka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@titusjaka @sashasushko