Add pattern matching workers #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titusjaka
reviewed
Jul 27, 2018
cmd/filter/main.go
Outdated
| @@ -57,6 +57,10 @@ func main() { | |||
| os.Exit(1) | |||
| } | |||
|
|
|||
| if config.Filter.MaxParallelChecks == 0 { | |||
| fmt.Fprint(os.Stderr, "MaxParallelChecks does not configured, filter does not started") | |||
There was a problem hiding this comment.
Правильнее написать:
MaxParallelChecks is not configured, filter does not start
This was referenced Aug 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have encountered a performance issues with moira-filter (slow metrics ingestion which resulted in false-positive NODATA alerts)
The problem is that we have a large number of incoming metrics from a single host (carbon-c-relay in our case).
Current implementation assigns single goroutine per connections for a relatively slow process of pattern matching.
By introducing separate pool of pattern matching workers we completely solved our problem with slow ingestion