fix(api): make triggers with seriesByTag function require at least one argument with a strict equality #988
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make triggers with seriesByTag function require at least one argument with a strict equality
This PR is intended to prevent Moira from saving too many metrics locally when someone creates/edits a trigger with a target that can match a lot of them.
With these changes seriesByTag must have at least one argument with equality operator and no wildcards.
Examples
Valid targets after the change
movingAverage(groupByTags(seriesByTag('project=my-test-project'), 'max'), '10min')
aliasByTags(seriesByTag('name=~*', 'tag1=val1', 'tag2=val2', 'tag3=val3*'),'tag')
Invalid targets after the change
seriesByTag('name=ab.bc.*.cd.*.ef')
aliasByTags(seriesByTag('name=~*'),'tag')
aliasByTags(seriesByTag('name=~*', 'tag1~=*val1*', 'tag2=*val2*'),'tag')