Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add remove subscriptions command #979

Merged
merged 13 commits into from
Jan 10, 2024

Conversation

almostinf
Copy link
Member

@almostinf almostinf commented Dec 27, 2023

Add remove subscriptions command

Added a new command to delete given subscriptions separated by semicolons

Example: cli --remove-subscriptions 'id1; id2; id3'

@almostinf almostinf requested a review from a team as a code owner December 27, 2023 13:12
@almostinf
Copy link
Member Author

/build

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (ad9cd9b) 68.19% compared to head (c835ba0) 68.09%.
Report is 1 commits behind head on master.

❗ Current head c835ba0 differs from pull request most recent head 90fe6a0. Consider uploading reports for the commit 90fe6a0 to get more accurate results

Files Patch % Lines
cmd/cli/main.go 0.00% 19 Missing ⚠️
notifier/notifier.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #979      +/-   ##
==========================================
- Coverage   68.19%   68.09%   -0.11%     
==========================================
  Files         208      208              
  Lines       11734    11752      +18     
==========================================
  Hits         8002     8002              
- Misses       3254     3272      +18     
  Partials      478      478              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@almostinf
Copy link
Member Author

/build

@almostinf
Copy link
Member Author

/build

@almostinf
Copy link
Member Author

/build

@almostinf
Copy link
Member Author

/build

@almostinf
Copy link
Member Author

/build

cmd/cli/main.go Outdated Show resolved Hide resolved
cmd/cli/main.go Outdated Show resolved Hide resolved
cmd/cli/main.go Outdated Show resolved Hide resolved
@almostinf
Copy link
Member Author

/build

@almostinf almostinf requested a review from kissken January 9, 2024 10:09
@almostinf almostinf merged commit e2291e8 into master Jan 10, 2024
7 checks passed
@almostinf almostinf deleted the feat/add-remove-subscriptions-cli-command branch January 10, 2024 10:33
Copy link

Build and push Docker images with tag: 2024-01-10.e2291e8

1 similar comment
Copy link

Build and push Docker images with tag: 2024-01-10.e2291e8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants