Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): add sentry dsn in web config #973

Merged
merged 6 commits into from
Jan 12, 2024
Merged

Conversation

almostinf
Copy link
Member

@almostinf almostinf commented Dec 12, 2023

Add sentry dsn in web config

Also refactor getWebConfig route

@almostinf almostinf requested a review from a team as a code owner December 12, 2023 14:26
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (ad9cd9b) 68.19% compared to head (8e8a4ca) 68.20%.

❗ Current head 8e8a4ca differs from pull request most recent head ec439dd. Consider uploading reports for the commit ec439dd to get more accurate results

Files Patch % Lines
api/handler/config.go 25.00% 2 Missing and 1 partial ⚠️
cmd/api/main.go 0.00% 2 Missing ⚠️
api/handler/handler.go 83.33% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #973      +/-   ##
==========================================
+ Coverage   68.19%   68.20%   +0.01%     
==========================================
  Files         208      208              
  Lines       11734    11730       -4     
==========================================
- Hits         8002     8001       -1     
+ Misses       3254     3251       -3     
  Partials      478      478              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@almostinf
Copy link
Member Author

/build

@almostinf
Copy link
Member Author

/build

@almostinf almostinf changed the title feat(api): add get sentry dsn route feat(api): add get sentry dsn in web config Dec 22, 2023
@almostinf almostinf changed the title feat(api): add get sentry dsn in web config feat(api): add sentry dsn in web config Dec 22, 2023
Tetrergeru
Tetrergeru previously approved these changes Dec 22, 2023
api/config.go Show resolved Hide resolved
kissken
kissken previously approved these changes Jan 9, 2024
api/config.go Outdated Show resolved Hide resolved
@kissken kissken self-requested a review January 9, 2024 06:54
@almostinf almostinf dismissed stale reviews from kissken and Tetrergeru via 4e466dc January 9, 2024 08:50
@almostinf
Copy link
Member Author

/build

@almostinf almostinf merged commit 41e0f1c into master Jan 12, 2024
7 checks passed
@almostinf almostinf deleted the feat/add-get-dsn-route branch January 12, 2024 07:20
Copy link

Build and push Docker images with tag: 2024-01-12.41e0f1c

2 similar comments
Copy link

Build and push Docker images with tag: 2024-01-12.41e0f1c

Copy link

Build and push Docker images with tag: 2024-01-12.41e0f1c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants