Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(linter): add linters and upgrade versions #960

Merged
merged 8 commits into from
Feb 5, 2024
Merged

Conversation

kissken
Copy link
Member

@kissken kissken commented Nov 9, 2023

No description provided.

@kissken kissken requested a review from a team as a code owner November 9, 2023 13:31
@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

Attention: 68 lines in your changes are missing coverage. Please review.

Comparison is base (a01185d) 68.10% compared to head (7f77d9e) 68.09%.

❗ Current head 7f77d9e differs from pull request most recent head 0431e3a. Consider uploading reports for the commit 0431e3a to get more accurate results

Files Patch % Lines
database/redis/metric.go 53.84% 5 Missing and 1 partial ⚠️
database/redis/reply/event.go 0.00% 4 Missing ⚠️
database/redis/reply/search_result.go 0.00% 4 Missing ⚠️
api/controller/team.go 78.57% 1 Missing and 2 partials ⚠️
database/redis/reply/contact.go 0.00% 3 Missing ⚠️
database/redis/tag.go 0.00% 2 Missing and 1 partial ⚠️
database/redis/trigger.go 70.00% 1 Missing and 2 partials ⚠️
expression/expression.go 0.00% 3 Missing ⚠️
image_store/s3/store.go 0.00% 3 Missing ⚠️
database/redis/notification_event.go 33.33% 0 Missing and 2 partials ⚠️
... and 28 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #960      +/-   ##
==========================================
- Coverage   68.10%   68.09%   -0.01%     
==========================================
  Files         208      208              
  Lines       11749    11752       +3     
==========================================
+ Hits         8002     8003       +1     
- Misses       3269     3271       +2     
  Partials      478      478              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kissken
Copy link
Member Author

kissken commented Feb 2, 2024

/build

@kissken kissken merged commit 6e09422 into master Feb 5, 2024
7 checks passed
@kissken kissken deleted the feature/new_linters branch February 5, 2024 05:07
Copy link

github-actions bot commented Feb 5, 2024

Build and push Docker images with tag: 2024-02-05.6e09422

1 similar comment
Copy link

github-actions bot commented Feb 5, 2024

Build and push Docker images with tag: 2024-02-05.6e09422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants