Fix bug when event was sent after maintenance even if state didn't change #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a remembers suppressed state and send alert if suppression is off and its state isn't equal to suppressed.
|
@borovskyav вроде всё сделал. Жду ревью :) |
borovskyav
approved these changes
Jun 6, 2018
There was a problem hiding this comment.
Черт, кароче я час пытался найти баг, кучу сценариев прокрутил, вообще не к чему докопаться, красавчик :) И тестами норм покрыл, вижу не зря тогда с тобой тогда посидели, думаю они тебе сильно жизнь спасли в этой задаче) Проверь как следует на стейджинге и кати)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.