Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added more linters #573

Merged
merged 15 commits into from
Sep 10, 2020
Merged

Added more linters #573

merged 15 commits into from
Sep 10, 2020

Conversation

zhelyabuzhsky
Copy link
Contributor

@zhelyabuzhsky zhelyabuzhsky commented Sep 7, 2020 •
edited
Loading

More linters

Added all linters from f288049 except gochecknoglobals because it generates too many errors and as I can see is not recommended by golandci

Relates #446

@zhelyabuzhsky zhelyabuzhsky requested a review from a team as a code owner September 7, 2020 14:39
@zhelyabuzhsky zhelyabuzhsky changed the title Added more linter Added more linters Sep 7, 2020
@coveralls
Copy link

coveralls commented Sep 7, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 80.896% when pulling f92ffd5 on zhelyabuzhsky:feature/lint into da83f70 on moira-alert:master.

@zhelyabuzhsky zhelyabuzhsky changed the title Added more linters WIP: Added more linters Sep 7, 2020
@zhelyabuzhsky zhelyabuzhsky changed the title WIP: Added more linters Added more linters Sep 7, 2020
@litleleprikon litleleprikon merged commit 620e228 into moira-alert:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litleleprikon litleleprikon litleleprikon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhelyabuzhsky @coveralls @litleleprikon