debug exception #552
Merged
debug exception #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nixolay
force-pushed
the
feature/debug_exception
branch
from
01dceb1
to
f8be308
Compare
borovskyav
suggested changes
Jun 19, 2020
There was a problem hiding this comment.
У меня сложилось впечатление что ты хотел сделать какой-то общий ключ, чтобы можно было быстро находить такие ошибки, сейчас ты используешь IGetRemoteTrigger но не все эти ошибки по remote давай как-то переименуем, во что-то типа TriggerCheckException (не настаиваю на названии).
Nixolay
force-pushed
the
feature/debug_exception
branch
from
f8be308
to
f15132e
Compare
Nixolay
force-pushed
the
feature/debug_exception
branch
from
f15132e
to
6fb0f3f
Compare
borovskyav
previously approved these changes
Jun 30, 2020
…ert/moira into feature/debug_exception
Nixolay
force-pushed
the
feature/debug_exception
branch
from
829454f
to
72de369
Compare
* Made a more understandable error caused by a request to a remote server * Removed tags that were placed earlier, as we already know the location of this error
Nixolay
force-pushed
the
feature/debug_exception
branch
from
72de369
to
220075c
Compare
borovskyav
approved these changes
Jul 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.