perf(checker): Improve performance of check #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borovskyav
previously approved these changes
Jun 11, 2020
litleleprikon
changed the title
added 2 commits
June 15, 2020 12:28
Function getMetricDataState is called very often and each time it called all params are copied. Change params types to pointers solves this problem. Relates #428
litleleprikon
force-pushed
the
feature/fix-metrics-copying
branch
from
5eaf2ef
to
3cb72a4
Compare
borovskyav
approved these changes
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In checker the most hot place is a calls for getMetricDataState function. This PR tries to improve performance of this calls.
Relates #428