Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: test on a non-primary database #529

Merged
merged 1 commit into from
Apr 10, 2020
Merged

feat: test on a non-primary database #529

merged 1 commit into from
Apr 10, 2020

Conversation

Nixolay
Copy link
Contributor

@Nixolay Nixolay commented Apr 6, 2020

No description provided.

@Nixolay Nixolay requested a review from a team April 6, 2020 14:49
@coveralls
Copy link

coveralls commented Apr 6, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.03%) to 80.522% when pulling ce6a9b2 on feature/test_on_a_non-primary_database into 92e5dd9 on master.

beevee
beevee requested changes Apr 7, 2020
View reviewed changes
database/redis/database.go Outdated Show resolved Hide resolved
database/redis/database.go Outdated Show resolved Hide resolved
@Nixolay Nixolay force-pushed the feature/test_on_a_non-primary_database branch from 885e05a to d7c7d26 Compare April 7, 2020 15:29
@Nixolay Nixolay requested a review from beevee April 7, 2020 19:05
litleleprikon
litleleprikon suggested changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@litleleprikon litleleprikon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it's ok but place for test configs should be discussed

database/redis/database_test.go Outdated Show resolved Hide resolved
@Nixolay Nixolay force-pushed the feature/test_on_a_non-primary_database branch from d7c7d26 to 7431292 Compare April 8, 2020 07:01
@Nixolay Nixolay force-pushed the feature/test_on_a_non-primary_database branch 4 times, most recently from 86d6a31 to e1fcc4b Compare April 8, 2020 08:03
litleleprikon
litleleprikon suggested changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@litleleprikon litleleprikon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that you missed some changes from your PR

database/redis/database.go Outdated Show resolved Hide resolved
@Nixolay Nixolay force-pushed the feature/test_on_a_non-primary_database branch 3 times, most recently from 07e1a8a to ce6a9b2 Compare April 8, 2020 09:30
beevee
beevee previously approved these changes Apr 9, 2020
View reviewed changes
@Nixolay Nixolay removed the request for review from litleleprikon April 9, 2020 13:57
feat: test on a non-primary database
3afebd7 
 - Create function NewTestDatabase
 - Remove function old newTestDatabase
 - Change tests
@Nixolay Nixolay force-pushed the feature/test_on_a_non-primary_database branch from ecac433 to 3afebd7 Compare April 9, 2020 14:00
@Nixolay Nixolay requested a review from beevee April 9, 2020 14:01
@litleleprikon litleleprikon merged commit 33f00d2 into master Apr 10, 2020
@litleleprikon litleleprikon deleted the feature/test_on_a_non-primary_database branch April 10, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litleleprikon litleleprikon litleleprikon approved these changes

@beevee beevee beevee approved these changes

Assignees
No one assigned
Labels
backend enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nixolay @coveralls @beevee @litleleprikon