Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check nil pointer #455

Merged
merged 2 commits into from
Nov 29, 2019
Merged

Check nil pointer #455

merged 2 commits into from
Nov 29, 2019

Conversation

Nixolay
Copy link
Contributor

@Nixolay Nixolay commented Nov 29, 2019

Sometimes moira can send nil instead of subscription

@coveralls
Copy link

coveralls commented Nov 29, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 79.968% when pulling 69e23ae on refactor/check-nil-pointers into 9164d4a on master.

fix(cli): Check nil pointers in users and subs
e626637 
During subscription transfer between users subscription and user can be nil. Add check to handle this situation
@Nixolay Nixolay merged commit 79c589a into master Nov 29, 2019
@Nixolay Nixolay deleted the refactor/check-nil-pointers branch November 29, 2019 11:38
@Nixolay Nixolay changed the title Check nil poiner Check nil pointer Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litleleprikon litleleprikon litleleprikon approved these changes

@beevee beevee beevee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nixolay @coveralls @beevee @litleleprikon