Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deleting tags that are used in existing subscriptions #393

Merged
merged 6 commits into from
Jul 22, 2019
Merged

fix deleting tags that are used in existing subscriptions #393

merged 6 commits into from
Jul 22, 2019

Conversation

Nixolay
Copy link
Contributor

@Nixolay Nixolay commented Jul 18, 2019

fix #344

@Nixolay Nixolay requested a review from borovskyav July 18, 2019 09:25
@beevee
Copy link
Member

beevee commented Jul 18, 2019

Тест удаления тега не проходит :)

borovskyav
borovskyav suggested changes Jul 18, 2019
View reviewed changes
Copy link
Contributor

@borovskyav borovskyav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да, в целом главная претезия, Коля, не забывай пожалуйста про тесты, они у нас быстрые. И не забывай писать свои.

@Nixolay
Copy link
Contributor Author

Nixolay commented Jul 18, 2019

Точно. Сейчас поправлю.

@Nixolay
Copy link
Contributor Author

Nixolay commented Jul 19, 2019

Поправил тест

@coveralls
Copy link

coveralls commented Jul 19, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 79.438% when pulling 2814fc4 on feature/subscriptions_tags into ae886eb on master.

@beevee beevee requested a review from borovskyav July 19, 2019 08:05
borovskyav
borovskyav suggested changes Jul 19, 2019
View reviewed changes
api/controller/tag.go Show resolved Hide resolved
@kamaev
Copy link
Contributor

kamaev commented Jul 19, 2019

Кстати, а может тут как раз будет удобнее выплёвывать id'шники всех триггеров и всех подписок, которые заняли этот тег?

@Nixolay Nixolay requested a review from borovskyav July 22, 2019 08:11
@borovskyav
Copy link
Contributor

Кстати, а может тут как раз будет удобнее выплёвывать id'шники всех триггеров и всех подписок, которые заняли этот тег?

Не, кажется что для пользователя это лишняя информация, а так мы сильно засрем само сообщение. Давай пока так оставим, будет необходиомсть, сделаем.

@borovskyav borovskyav merged commit f122777 into master Jul 22, 2019
@borovskyav borovskyav deleted the feature/subscriptions_tags branch July 22, 2019 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borovskyav borovskyav borovskyav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disallow deleting tags that are used in existing subscriptions
5 participants
@Nixolay @beevee @coveralls @kamaev @borovskyav