Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images in notifications #148

Merged
merged 66 commits into from
Dec 19, 2018
Merged

Images in notifications #148

merged 66 commits into from
Dec 19, 2018

Conversation

kamaev
Copy link
Contributor

@kamaev kamaev commented Dec 16, 2018 •
edited
Loading

  • added subscription plotting parameters
  • added remote storage and carbonapi functions support to notifier
  • added plotting to senders:
    • slack (reply to thread)
    • telegram (reply to alert)
    • pushover (attachment)
    • mail

@borovskyav
Copy link
Contributor

borovskyav commented Dec 18, 2018 •
edited
Loading

Совсем забыл. Давай сделаем конвертер, который проставляет plotting enabled = true. Предполагаю есть не только парни из Авито, которые хотят чтобы картиночки по умолчанию были. Только будь осторожнее, я там влил перефигаченный cli. Лучше сначала develop к себе забери свежий

@kamaev kamaev added the WIP Work in progress label Dec 18, 2018
@kamaev kamaev removed the WIP Work in progress label Dec 18, 2018
borovskyav
borovskyav reviewed Dec 19, 2018
View reviewed changes
Copy link
Contributor

@borovskyav borovskyav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Все четко! Тестов решил не дописывать больше? Меня очень смущает -1.2% coverage

@kamaev
Copy link
Contributor Author

kamaev commented Dec 19, 2018

Я еще сегодня перепроверю все, поиграюсь с настройками и если что то еще обнаружу или додумаю то обязательно втащу в ветку

Цвета трешхолдов для светлой темы кстати поправил в этом pr, они теперь не такие вырвиглазые как были

@borovskyav
Copy link
Contributor

Тимур, не затягивай, там еще мои ветки надо посмотреть.

@kamaev kamaev merged commit 5f974a3 into develop Dec 19, 2018
@kamaev kamaev mentioned this pull request Dec 19, 2018
Closed
This was referenced Dec 25, 2018
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borovskyav borovskyav borovskyav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kamaev @coveralls @borovskyav @titusjaka