The same logic as in #113, but reversed #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borovskyav
approved these changes
Sep 5, 2018
|
Не увидел правку в вебе |
|
потому что её ещё нет 😃 |
titusjaka
added a commit
to moira-alert/web2.0
that referenced
this pull request
Sep 5, 2018
|
Проверил на стейджинге. Работает точно так же, как было. Только теперь поведению по умолчанию: присылать уведомления. |
titusjaka
added a commit
to moira-alert/doc
that referenced
this pull request
Sep 5, 2018
This was referenced Dec 25, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverse default behavior of Moira when new metrics are received. It is almost the same as #113 but by default Moira will send
NODATA - OKevents.