perf(filter): improved handling of non-strict asterisk tags #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/build |
Tetrergeru
reviewed
Jul 9, 2024
Tetrergeru
reviewed
Jul 9, 2024
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1050 +/- ##
==========================================
- Coverage 67.92% 67.55% -0.37%
==========================================
Files 212 213 +1
Lines 12024 12230 +206
==========================================
+ Hits 8167 8262 +95
- Misses 3359 3458 +99
- Partials 498 510 +12 ☔ View full report in Codecov by Sentry. |
Tetrergeru
previously approved these changes
Jul 9, 2024
Tetrergeru
approved these changes
Jul 9, 2024
|
/build |
|
Build and push Docker images with tag: 2024-07-10.c191a9b |
1 similar comment
|
Build and push Docker images with tag: 2024-07-10.c191a9b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved handling of non-strict asterisk tags
It doesn't make sense to create a new regular expression for tags like
tag=~*,tag=~.*,tag!=~*ortag!=~.*, because in such tags it is the fact of presence or absence of a tag that matters, not its value. This can reduce the total number of expensiveregexp.MatchStringoperations in filters