refactor(notifier): rescheduling delay #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At notifier/scheduler.go inside StandardScheduler.ScheduleNotification on sending fail the next scheduling time was always now + 1 minute. Now you can change this 1 minute to some other value. Also, the ScheduleNotification interface had many params, so struct notifier.SchedulerParams is now used.
Because of using new struct as a scheduler params and new configurable value tests and test data should be corrected
Because of using new struct as a scheduler params and new configurable value tests and test data should be corrected
…sko/moira into refactor/rescheduling-delay
If delay time is the same as rescheduling delay then delayed notifications may not be considered delayed
almostinf
reviewed
Jul 4, 2024
almostinf
reviewed
Jul 4, 2024
almostinf
reviewed
Jul 4, 2024
Tetrergeru
reviewed
Jul 4, 2024
| @@ -94,15 +96,16 @@ func getDefault() config { | |||
| NotificationHistoryQueryLimit: int(notifier.NotificationsLimitUnlimited), | |||
| }, | |||
| Notification: cmd.NotificationConfig{ | |||
| DelayedTime: "1m", | |||
| DelayedTime: "50s", | |||
There was a problem hiding this comment.
А почему решил поменять тут значение по умолчанию?
There was a problem hiding this comment.
К задаче прикреплено обсуждение по этому поводу. Получается если DelayedTime == ReschedulingDelay, то ScheduledNotification не считается отложенной (delayed) тык.
Ну и также поменял данное значение в local/notifier.yml
There was a problem hiding this comment.
Обсуждение прочитал, но может логичнее условие сделать строгим, вместо того, чтобы время костылить с 60 на 50 секунд?
almostinf
reviewed
Jul 5, 2024
almostinf
previously approved these changes
Jul 8, 2024
Previous commit has problems with tests in database/redis
almostinf
approved these changes
Jul 11, 2024
Tetrergeru
approved these changes
Jul 11, 2024
|
/build |
|
Build and push Docker images with tag: refactor-rescheduling-delay.2024-07-11.1513373 |
almostinf
merged commit 2aa786d
into
moira-alert:refactor/rescheduling-delay
6 checks passed
almostinf
added a commit
that referenced
this pull request
Jul 15, 2024
Authored-by: Aleksandr Matsko (@AleksandrMatsko)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configurable rescheduling delay in notifier
On failured sending notifier scheduled another notification on
time.Now() + 1 minute. Now this additional time can be configured.