Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(filter): add metric for pattern matching cache #1042

Conversation

almostinf
Copy link
Member

Add metric for pattern matching cache

Added a metric to count the number of evicted keys from the pattern matching cache to notice this later and increase the cache size

@almostinf almostinf requested a review from a team as a code owner June 25, 2024 11:38
@almostinf
Copy link
Member Author

/build

@almostinf
Copy link
Member Author

/build

Copy link

Build and push Docker images with tag: feat-add-metrics-for-pattern-matching-cache.2024-06-25.8d3fc4b

1 similar comment
Copy link

Build and push Docker images with tag: feat-add-metrics-for-pattern-matching-cache.2024-06-25.8d3fc4b

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat/cache-regex-for-tags@c276821). Learn more about missing BASE report.

Current head 04dfb68 differs from pull request most recent head 313b327

Please upload reports for the commit 313b327 to get more accurate results.

Files Patch % Lines
filter/series_by_tag_pattern_index.go 50.00% 1 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                     Coverage Diff                      @@
##             feat/cache-regex-for-tags    #1042   +/-   ##
============================================================
  Coverage                             ?   67.55%           
============================================================
  Files                                ?      213           
  Lines                                ?    12223           
  Branches                             ?        0           
============================================================
  Hits                                 ?     8257           
  Misses                               ?     3457           
  Partials                             ?      509           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@almostinf almostinf merged commit 6cb9e9c into feat/cache-regex-for-tags Jun 26, 2024
4 checks passed
@almostinf almostinf deleted the feat/add-metrics-for-pattern-matching-cache branch June 26, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants