Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): forbidden create unresolved contact type #1030

Merged
merged 3 commits into from
May 23, 2024

Conversation

almostinf
Copy link
Member

Impossible create unresolved contact type

@almostinf almostinf requested a review from a team as a code owner May 23, 2024 13:59
@@ -15,6 +15,8 @@ import (
"github.com/moira-alert/moira/database"
)

var ErrNotAllowedContactType = errors.New("CreateContact: cannot create contact with not allowed contact type")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

godoc

@almostinf almostinf requested a review from kissken May 23, 2024 14:37
@almostinf almostinf changed the title feat(api): impossible create unresolved contact type feat(api): forbidden create unresolved contact type May 23, 2024
@almostinf
Copy link
Member Author

/build

@almostinf almostinf merged commit f8ec459 into master May 23, 2024
7 checks passed
@almostinf almostinf deleted the feat/impossible-create-unresolved-contact branch May 23, 2024 15:09
Copy link

Build and push Docker images with tag: 2024-05-23.f8ec459

1 similar comment
Copy link

Build and push Docker images with tag: 2024-05-23.f8ec459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants