Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade version and add new linters #1000

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Conversation

kissken
Copy link
Member

@kissken kissken commented Mar 18, 2024

set version 1.56
and added new linters

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 67.72%. Comparing base (6724bf7) to head (1234a30).

❗ Current head 1234a30 differs from pull request most recent head ccbf725. Consider uploading reports for the commit ccbf725 to get more accurate results

Files Patch % Lines
api/middleware/logger.go 0.00% 1 Missing ⚠️
checker/trigger_checker.go 0.00% 1 Missing ⚠️
cmd/cli/main.go 0.00% 1 Missing ⚠️
notifier/plotting.go 50.00% 1 Missing ⚠️
senders/msteams/msteams.go 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1000      +/-   ##
==========================================
- Coverage   67.74%   67.72%   -0.02%     
==========================================
  Files         208      208              
  Lines       11955    11949       -6     
==========================================
- Hits         8099     8093       -6     
  Misses       3358     3358              
  Partials      498      498              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kissken kissken marked this pull request as ready for review March 18, 2024 07:18
@kissken kissken requested a review from a team as a code owner March 18, 2024 07:18
notifier/registrator.go Outdated Show resolved Hide resolved
@kissken kissken merged commit f1e51ba into master Mar 20, 2024
6 checks passed
@kissken kissken deleted the feat/upgrade_linter_version branch March 20, 2024 10:47
Copy link

Build and push Docker images with tag: 2024-03-20.f1e51ba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants