Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add templates to trigger description #484

Closed
litleleprikon opened this issue Jan 13, 2020 · 0 comments · Fixed by #487
Closed

Add templates to trigger description #484

litleleprikon opened this issue Jan 13, 2020 · 0 comments · Fixed by #487

Comments

@litleleprikon
Copy link
Contributor

litleleprikon commented Jan 13, 2020

It's often useful to add a Grafana dashboard link to a trigger description. But sometimes you have a templated dashboard. That is, you need to pass a specific variable value (e.g. host name) to open a dashboard that is relevant to the alert.

For example:
https://grafana.yourhost.com/some-dashboard?var-host=-METRICNAME-

We can add templating capabilities to our trigger descriptions to fill and render values at notification generation time.

Some things to consider:

  1. What if a notification contains several events? How do we render the description? Do we pass an array of values to the template?
  2. What do we render in web UI? A template? This can make links on the web unusable.
  3. Which template language do we use? Which variables do we pass when rendering the template? Which templating capabilities do we allow so we don't compromise security?
@litleleprikon litleleprikon changed the title # Add templates to trigger description Add templates to trigger description Jan 13, 2020
Nixolay pushed a commit that referenced this issue Jan 23, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Jan 27, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Jan 27, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Jan 27, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Jan 28, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Jan 28, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Jan 28, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Jan 31, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Feb 4, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Feb 7, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Feb 11, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Feb 12, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Feb 12, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Feb 14, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Feb 14, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Feb 14, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Feb 14, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Feb 14, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Feb 17, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Feb 17, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Feb 18, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Feb 18, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Feb 18, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Feb 19, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Feb 26, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Feb 26, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Feb 27, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Feb 27, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Feb 27, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Feb 27, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Feb 27, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Apr 8, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Nixolay pushed a commit that referenced this issue Apr 10, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
litleleprikon pushed a commit that referenced this issue Apr 10, 2020
* Added templates to trigger description
* Added presentation of trigger description in non-editing for api

Closed #484
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants