Change dependency downloading documentation #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beevee
requested changes
Oct 2, 2019
source/development/notifier.rst
Outdated
| @@ -9,8 +9,7 @@ To run tests, first get all dependencies. | |||
|
|
|||
| .. code-block:: bash | |||
|
|
|||
| go get github.com/kardianos/govendor | |||
| govendor sync | |||
| go get ./... | |||
There was a problem hiding this comment.
Do we need this at all? Maybe goconvey runs without explicitly go get-ting dependencies? Please, investigate.
Change dependency fetching described in source/development/notifier.rst from govendor way to go modules. Relates moira-alert/moira#423
litleleprikon
force-pushed
the
423-migrate-to-modules
branch
from
f72b71b
to
4ed205f
Compare
beevee
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change dependency fetching described in source/development/notifier.rst
from govendor way to go modules.
Relates moira-alert/moira#423