Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generate client from actual spec #10

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: generate client from actual spec #10

wants to merge 3 commits into from
+1,035 −699

Conversation

AleksandrMatsko
Copy link
Member

@AleksandrMatsko AleksandrMatsko commented Nov 27, 2024 •
edited
Loading

PR Summary

Regenerate client for Moira from new spec:

  • 503 error for /api/trigger/check.
  • Added constants for day names.
  • Differ gel all teams and get all teams for user endpoints.
  • Remove old files.

Generate with command

swagger generate client -f path/to/moira/docs/swagger.json -A moira-api

@AleksandrMatsko AleksandrMatsko marked this pull request as ready for review November 29, 2024 09:52
kissken
kissken reviewed Dec 2, 2024
View reviewed changes
pkg/client/notification/delete_notification_parameters.go
@@ -1,169 +0,0 @@
// Code generated by go-swagger; DO NOT EDIT.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

это что-то неактуальное, да?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kissken kissken kissken left review comments

@Tetrergeru Tetrergeru Awaiting requested review from Tetrergeru

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AleksandrMatsko @kissken