Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed errors and warnings in Xcode 12 #3

Merged
merged 2 commits into from
Feb 20, 2021
Merged

fixed errors and warnings in Xcode 12 #3

merged 2 commits into from
Feb 20, 2021

Conversation

recherst
Copy link
Contributor

fit to Xcode 12 and iOS 14.4

fit to Xcode 12 and iOS 14.4
@recherst
Copy link
Contributor Author

recherst commented Feb 20, 2021

I add this library in my project and can not build successfully. I had solved this problem and some warnings in Xcode 12. please check it as soon as possible cause I'm waiting to use.
thanks!

@@ -6,7 +6,7 @@ final class PhotoLibraryPickerTests: XCTestCase {
// This is an example of a functional test case.
// Use XCTAssert and related functions to verify your tests produce the correct
// results.
XCTAssertEqual(PhotoLibraryPicker().text, "Hello, World!")
// XCTAssertEqual(PhotoLibraryPicker(<#Binding<[Picture]>#>).text, "Hello, World!")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete it :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete it :)

all right

@moifort
Copy link
Owner

moifort commented Feb 20, 2021

Thanks for your PR. Just one comment :).

@recherst
Copy link
Contributor Author

Thanks for your PR. Just one comment :).

thanks a lot :)

@moifort
Copy link
Owner

moifort commented Feb 20, 2021

👍🏻👍🏻👍🏻

@moifort moifort merged commit d1b39aa into moifort:master Feb 20, 2021
@recherst
Copy link
Contributor Author

waiting for your new release version.

@moifort
Copy link
Owner

moifort commented Feb 20, 2021

Oh thanks to warn me! I will do it right now!

@recherst
Copy link
Contributor Author

Oh thanks to warn me! I will do it right now!

Excuse me, is there a new release version? I'm waiting for you...

@moifort
Copy link
Owner

moifort commented Feb 22, 2021

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants