Use Xsource:3 #232
Merged
Use Xsource:3 #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saeltz
requested review from
CristinaHG,
JannikArndt,
joroKr21 and
markus1189
as code owners
joroKr21
reviewed
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scala 3 is deprecating package objects with inheritance (see scala/scala-dev#441). We were using them quite a lot.
This uses the compiler flag
-Xsource:3to err on features deprecated in Scala 3 and changes package objects to normal objects which requires some shifting of files to keep the imports stable.This is the first PR of many to support Scala 3.