Bugfix - update type when updating value. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my app a value changes from `"sample1"` to `false`. It changes the type from `string` to `boolean`. This caused an error: Before: An error is thrown, because `escapeString` cannot escape a boolean (i.e. booleans don't have a `replace` function) After: No error is thrown.
mohsen1
added a commit
that referenced
this pull request
Dec 16, 2014
Bugfix - update type when updating value.
|
👍 |
mohsen1
added a commit
that referenced
this pull request
Dec 16, 2014
|
@markmarijnissen FYI Your fix missed the fact that we put |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my app a value changes from
"sample1"tofalse.It changes the type from
stringtoboolean.This caused an error:
Before: An error is thrown, because
escapeStringcannot escape a boolean (i.e. booleans don't have areplacefunction)After: No error is thrown.