Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkers: Add checker for Janet #40

Merged
merged 5 commits into from
Sep 3, 2024

Conversation

alternateved
Copy link
Contributor

Hello!

I would like to add support for Janet checker.

@alternateved
Copy link
Contributor Author

alternateved commented Aug 21, 2024

Hmm, I'm not entirely sure why installer file cannot be run in pipeline:

#12 82.39 find: 'installers/janet.bash': Permission denied

I don't have docker installed (and it would be hard for me to do so on this machine) so I cannot test that locally.

@mohkale
Copy link
Owner

mohkale commented Sep 2, 2024

@alternateved

Looks like it's because the installer is not executable. You'll wanna run chmod +x on it.

(HEAD) λ stat janet.bash
  File: janet.bash
  Size: 265             Blocks: 8          IO Block: 4096   regular file
Device: 8,17    Inode: 17098924    Links: 1
Access: (0644/-rw-r--r--)  Uid: ( 1000/ mohkale)   Gid: ( 1001/ mohkale)
Access: 2024-09-02 20:31:27.589757645 +0100
Modify: 2024-09-02 20:31:27.563090934 +0100
Change: 2024-09-02 20:31:27.563090934 +0100
 Birth: 2024-09-02 20:31:27.563090934 +0100

@alternateved
Copy link
Contributor Author

Thanks! I was scratching my head on that while solution was that simple.

Copy link
Owner

@mohkale mohkale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-). Extra thank you for adding tests.

@mohkale mohkale merged commit ecc15c7 into mohkale:release Sep 3, 2024
4 checks passed
@alternateved alternateved deleted the add-janet-support branch September 3, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants