Rename cri sock #52
Open
Rename cri sock #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogren
force-pushed
the
rename-cri-sock
branch
3 times, most recently
from
b003163
to
9883f62
Compare
mogren
force-pushed
the
rename-cri-sock
branch
2 times, most recently
from
47ba0a8
to
d1af209
Compare
mogren
force-pushed
the
rename-cri-sock
branch
from
d1af209
to
d101bdf
Compare
Resolves aws#1261, since having a minimum IP target lower than the warm IP target doesn't really make sense.
mogren
force-pushed
the
rename-cri-sock
branch
from
d101bdf
to
339caa1
Compare
Our legal team has asked that the wording included in the CONTRIBUTING.md document referring to potentially requiring a CLA to be signed for certain contributions be removed. This phrase was added out of an abundance of caution originally and has been determined to be unnecessary and inhibiting external contribution.
Added retry for sync issues move TOKEN inside get_metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
What this PR does / why we need it:
If issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing:
Automation added to e2e:
Will this break upgrades and downgrades. Has it been tested?:
Does this require config only upgrades?:
Does this PR introduce a user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.