-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull Request: PHP 8 Upgrade with Feature Enhancements and Bug Fixes #190
Open
yama
wants to merge
97
commits into
master
Choose a base branch
from
php8
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_tag and select_tag functions
…_installer.processor.php
…ert2utf8mb4 function
…ck in welcome.static.php
…e settings_version
… convert2utf8mb4.php
…n initialize.functions.inc.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on adapting the project codebase to PHP 8, while also improving code consistency, enhancing error handling, and optimizing database operations.
Key Changes:
PHP 8 Compatibility:
Enhanced Error Handling:
temp/
) and configuration values.Database Operations Optimization:
fix_settings.php
, was added to ensure smooth handling of missing columns.Additional Improvements:
These changes collectively improve reliability and performance under PHP 8, while also addressing long-standing issues revealed by the migration. This effort served as an opportunity to enhance the overall quality of the codebase.
(日本語)
このプルリクエストでは、プロジェクトのコードベースをPHP 8に対応させるための変更を中心に、コードの一貫性向上、エラーハンドリングの強化、データベース操作の最適化を行いました。
主な変更点:
PHP 8 対応:
エラーハンドリングの強化:
temp/
ディレクトリや設定値の事前チェックを追加。データベース操作の最適化:
fix_settings.php
スクリプトを新たに追加し、カラムが存在しない場合の動作を保証。その他の改善:
これらの変更により、PHP 8環境での動作信頼性とパフォーマンスが大幅に向上しました。また、これを機に、コード全体の品質を向上させるための追加修正も行っています。