Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add dev.client.port to support hmr #4287

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fix: add dev.client.port to support hmr #4287

merged 1 commit into from
Oct 8, 2024

Conversation

2heal1
Copy link
Member

@2heal1 2heal1 commented Oct 8, 2024

The hmr failed because rsbuild correct the server.port meanings , it not equals dev.client.port related pr web-infra-dev/rsbuild#2639

@2heal1 2heal1 enabled auto-merge (squash) October 8, 2024 03:21
Copy link

github-actions bot commented Oct 8, 2024

Workflow status is success ✅
Unfortunately test report wasn't generated, it can be if no workspaces changed. Please check the workflow run below.
Link to GitHub workflow: Github Workflow Link

@github-actions github-actions bot added the workflow-success All good label Oct 8, 2024
@2heal1 2heal1 merged commit 2b54e15 into master Oct 8, 2024
9 checks passed
@2heal1 2heal1 deleted the fix/update-port branch October 8, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants