chore: add license info #3143
Merged
chore: add license info #3143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![squadronai[bot]](https://avatars.githubusercontent.com/in/901096?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary
This pull request adds license information and makes various improvements to the codebase of the enhanced and nextjs-mf packages.
The key changes include:
- Adding MIT license headers and author information to multiple files, ensuring proper licensing and attribution.
- Refactoring and simplifying the code in the
ModuleFederationPluginandFederationRuntimePlugin, improving maintainability and readability. - Enhancing the functionality of the
FederationRuntimePluginby adding support for embedding the federation runtime, modifying the entry point, and handling federation module dependencies. - Introducing a fallback mechanism in the
StartupHelpers.tsfile to handle changes in the structure of thecompilation.compiler.webpackobject. - Optimizing the
InvertedContainerRuntimeModuleby removing thefindEntryModuleOfContainer()method and adding a new condition to thegenerate()method.
These changes aim to improve the overall quality, maintainability, and compliance of the project's codebase.
File Summaries
| File | Summary |
|---|---|
| packages/enhanced/src/lib/container/AsyncBoundaryPlugin.ts | This code change adds license information to the AsyncBoundaryPlugin.ts file, which is part of the enhanced package. The license information includes the MIT License and the author's name, Zackary Jackson. The primary purpose of this change is to provide clear licensing details for the file and ensure compliance with the project's licensing requirements. |
| packages/enhanced/src/lib/container/ModuleFederationPlugin.ts | The code changes add a new line after the compiler.options.output.enabledLibraryTypes?.push(library.type); statement and introduce a new ContainerPlugin instance within the afterPlugins hook of the ModuleFederationPlugin. These modifications likely aim to enhance the functionality and configuration of the Module Federation plugin in the context of the project. |
| packages/enhanced/src/lib/container/constant.ts | The code changes introduce license information and author details at the top of the file. The primary purpose is to provide licensing and attribution details for the code. |
| packages/enhanced/src/lib/container/runtime/ChildCompilationRuntimePlugin.ts | The code changes introduce license information and comments to the ChildCompilationRuntimePlugin.ts file. The primary purpose of these modifications is to provide licensing details and author attribution for the file. |
| packages/enhanced/src/lib/container/runtime/EmbedFederationRuntimeModule.ts | The code changes add a license information header to the EmbedFederationRuntimeModule file, which is a part of the @module-federation/sdk package. The changes also include minor formatting updates, such as adding empty lines for better readability, without modifying the core functionality of the module. |
| packages/enhanced/src/lib/container/runtime/FederationModulesPlugin.ts | The code changes introduce a refactoring to the compilationHooksMap variable, simplifying the type definition and making it more concise. The primary purpose of this change is to improve the maintainability and readability of the codebase. |
| packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts | The code changes introduce a new plugin called "FederationRuntimePlugin" that enhances the functionality of the Module Federation feature in Webpack. The plugin adds support for embedding the federation runtime, modifying the entry point to include the federation runtime, and handling federation module dependencies. Additionally, it integrates with the "PrefetchPlugin" to enable data prefetching for the federation modules. |
| packages/enhanced/src/lib/container/runtime/utils.ts | The code changes introduce a license header at the top of the file, providing information about the MIT license and the author of the code. The primary purpose of this change is to add licensing details to the file, ensuring proper attribution and legal compliance. |
| packages/enhanced/src/lib/startup/StartupHelpers.ts | The code changes introduce a fallback mechanism to handle the case where the JavascriptModulesPlugin property is not directly available on the compilation.compiler.webpack object. This ensures that the generateESMEntryStartup function can still function correctly, even if the structure of the compilation.compiler.webpack object changes in the future. |
| packages/nextjs-mf/src/plugins/container/InvertedContainerRuntimeModule.ts | The code changes remove the findEntryModuleOfContainer() method and add a new condition to the generate() method. The purpose of these changes is to ensure that the runtime module is not applied to the remote entry module itself, as it is already handled by the container entry module. |
There was a problem hiding this comment.
Incremental Review
Comments posted: 17
Configuration
Squadron Mode: essential
Commits Reviewed
0931fc55772ac74c14a80a0fce28a96495afc0bb...fd07cb1556f98e0fe769edb9eb7d5695fc73c7b1
Files Reviewed
- packages/enhanced/src/lib/container/AsyncBoundaryPlugin.ts
- packages/enhanced/src/lib/container/ModuleFederationPlugin.ts
- packages/enhanced/src/lib/container/constant.ts
- packages/enhanced/src/lib/container/runtime/ChildCompilationRuntimePlugin.ts
- packages/enhanced/src/lib/container/runtime/EmbedFederationRuntimeModule.ts
- packages/enhanced/src/lib/container/runtime/FederationModulesPlugin.ts
- packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts
- packages/enhanced/src/lib/container/runtime/utils.ts
- packages/enhanced/src/lib/startup/StartupHelpers.ts
- packages/nextjs-mf/src/plugins/container/InvertedContainerRuntimeModule.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Types of changes
Checklist