Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs-mf): change runtimePlugin definition order #2052

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

ryok90
Copy link
Contributor

@ryok90 ryok90 commented Jan 30, 2024

Description

The errorLoadRemote hook was being overridden by the default runtimePlugin definition from within the nextjs-mf plugin.
This changes the order of the definition to take in the user-provided plugin lastly so it overrides the default.

Related Issue

This should solve #2039.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@ScriptedAlchemy
Copy link
Member

@ryok90 please run changeset add in branch and push it

@ScriptedAlchemy ScriptedAlchemy merged commit 845bc52 into module-federation:main Jan 31, 2024
4 checks passed
@2heal1 2heal1 mentioned this pull request Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants