Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: vitest not throw error while using @nx/vite:test directly #1855

Merged
merged 1 commit into from
Dec 28, 2023
Merged

fix: vitest not throw error while using @nx/vite:test directly #1855

merged 1 commit into from
Dec 28, 2023

Conversation

2heal1
Copy link
Member

@2heal1 2heal1 commented Dec 28, 2023

Description

before(can not see error infos) :
image
after:
image

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@2heal1 2heal1 requested a review from zhoushaw December 28, 2023 04:17
@ScriptedAlchemy
Copy link
Member

It looks like next e2e is getting stuck in main as of recent. You can merge if approved.

@zhoushaw zhoushaw merged commit 5749eec into main Dec 28, 2023
7 of 8 checks passed
@zhoushaw zhoushaw deleted the fix/runtime-test-no-throw-error branch December 28, 2023 04:42
@zhoushaw zhoushaw mentioned this pull request Dec 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhoushaw zhoushaw zhoushaw approved these changes

Assignees
No one assigned
Labels
change: fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@2heal1 @ScriptedAlchemy @zhoushaw