fix: not duplicate set resolve.alias (#1948)

module-federation · Jan 15, 2024 · 1147f48 · 1147f48
1 parent cf8634d
commit 1147f48
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/.changeset/lemon-fans-tickle.md b/.changeset/lemon-fans-tickle.md
@@ -0,0 +1,5 @@
+---
+'@module-federation/enhanced': patch
+---
+
+fix: not duplicate set resolve.alias
diff --git a/packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts b/packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts
@@ -205,13 +205,22 @@ class FederationRuntimePlugin {
         paths: [this.options.implementation],
       });
     }
+    if (Array.isArray(compiler.options.resolve.alias)) {
+      return;
+    }
 
     compiler.options.resolve.alias = {
       ...compiler.options.resolve.alias,
-      '@module-federation/runtime$': runtimePath,
-      '@module-federation/runtime-tools$':
-        this.options?.implementation || RuntimeToolsPath,
     };
+
+    if (!compiler.options.resolve.alias['@module-federation/runtime$']) {
+      compiler.options.resolve.alias['@module-federation/runtime$'] =
+        runtimePath;
+    }
+    if (!compiler.options.resolve.alias['@module-federation/runtime-tools$']) {
+      compiler.options.resolve.alias['@module-federation/runtime-tools$'] =
+        this.options?.implementation || RuntimeToolsPath;
+    }
   }
 
   apply(compiler: Compiler) {