Fix composer tests (hashicorp#4323) (hashicorp#2795)

Signed-off-by: Modular Magician <[email protected]>
modular-magician · Dec 17, 2020 · bf4a427 · bf4a427
1 parent ce97821
commit bf4a427
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 5 deletions.
diff --git a/.changelog/4323.txt b/.changelog/4323.txt
@@ -0,0 +1,3 @@
+```release-note:none
+
+```
diff --git a/google-beta/data_source_google_composer_environment.go b/google-beta/data_source_google_composer_environment.go
@@ -7,9 +7,17 @@ import (
 )
 
 func dataSourceGoogleComposerEnvironment() *schema.Resource {
+	dsSchema := datasourceSchemaFromResourceSchema(resourceComposerEnvironment().Schema)
+
+	// Set 'Required' schema elements
+	addRequiredFieldsToSchema(dsSchema, "name")
+
+	// Set 'Optional' schema elements
+	addOptionalFieldsToSchema(dsSchema, "project", "region")
+
 	return &schema.Resource{
 		Read:   dataSourceGoogleComposerEnvironmentRead,
-		Schema: resourceComposerEnvironment().Schema,
+		Schema: dsSchema,
 	}
 }
 

diff --git a/google-beta/data_source_google_composer_environment_test.go b/google-beta/data_source_google_composer_environment_test.go
@@ -104,9 +104,8 @@ resource "google_compute_subnetwork" "test" {
 }
 
 data "google_composer_environment" "test" {
-	name = google_composer_environment.test.name
-
-	depends_on = [google_composer_environment.test]
+	name   = google_composer_environment.test.name
+	region = google_composer_environment.test.region
 }
 `, context)
 }
diff --git a/google-beta/resource_composer_environment_test.go b/google-beta/resource_composer_environment_test.go
@@ -881,7 +881,7 @@ resource "google_composer_environment" "test" {
 		}
 		software_config {
 			pypi_packages = {
-				scipy = "==1.1.0"
+				numpy = ""
 			}
 		}
 	}