This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Add instance group manager resource to InSpec #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rambleraptor
approved these changes
Jan 14, 2019
| attr_reader :restarting | ||
|
|
||
| def initialize(args = nil) | ||
| return if args.nil? |
There was a problem hiding this comment.
Since args is a Hash, you could do all of these assignments as a one-liner if you wanted to.
Something like 'args.each |x| instance_variable_set("@#{x}", args[x])' (pretty sure there's an even cleaner way).
More of a heads-up. I don't have an opinion either way.
There was a problem hiding this comment.
I believe it is possible for these nested objects to contain further nested objects, which require passing args[x] to an initialize method. So I think it's better to keep these similar to the general resource parse method.
modular-magician
force-pushed
the
codegen-pr-1246
branch
3 times, most recently
from
9aaa0c9 to
4073a87
Compare
Signed-off-by: Modular Magician <[email protected]>
modular-magician
force-pushed
the
codegen-pr-1246
branch
from
4073a87 to
c81375b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @slevenick