This repository has been archived by the owner on Nov 14, 2024. It is now read-only.
Add additional fields to Memcached Instance #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Modular Magician <[email protected]>
slevenick
added a commit
that referenced
this pull request
Oct 27, 2020
* fix typo (#3369) (#413) Signed-off-by: Modular Magician <[email protected]> * Fix check for serial port disabled (#3695) (#415) * Fix check for serial port disabled * fix check for block-project-ssh-keys Signed-off-by: Modular Magician <[email protected]> * Add mode enum and scale down controls for Compute AutoScaler (#3693) (#416) * Add mode enum and scale down controls for Compute AutoScaler * Add mode enum for Compute AutoScaler in the correct API block * Add defaults for mode and default_from_api for scale down controls * Add tests for scale_down_controls and set at_least_one_of for it Signed-off-by: Modular Magician <[email protected]> * added support for shielded nodes in container (#3639) (#417) Signed-off-by: Modular Magician <[email protected]> * fix memcache_parameters (#3733) (#418) * change memcacheParameters to parameters, add parameters to basic test * make switching memcacheParameters to parameters not a breaking-change Signed-off-by: Modular Magician <[email protected]> * add tiers and nfs_export_options (#3766) (#419) * add tiers and nfs_export_options * update docs, make full test beta Signed-off-by: Modular Magician <[email protected]> * Add skip enum value generation (#3767) (#420) * Add skip enum value generation * Fix default * Fix reader * Fix line spacing on enum values Signed-off-by: Modular Magician <[email protected]> * Backend service support for internet NEG backend (#3782) (#421) * Add ability to set global network endpoint group as backend for backend service. Make health_checks optional * PR fixes * Add encoder to remove max_utilization when neg backend * Check for global NEG in group to remove max_utilization * Add another nil check * Spacing * Docs fix Signed-off-by: Modular Magician <[email protected]> * add firewall logging controls (#3780) (#422) * add firewall logging controls * make backward compatible * check enable_logging in expand * update docs * update expand logic to fix failing test Signed-off-by: Modular Magician <[email protected]> * Fix colon in doc notes (#3796) (#423) Signed-off-by: Modular Magician <[email protected]> * Add persistence_iam_identity to Redis Instance (#3805) (#424) Signed-off-by: Modular Magician <[email protected]> * Org Security Policies (Hierarchical Firewalls) (#3626) (#425) Co-authored-by: Dana Hoffman <[email protected]> Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Dana Hoffman <[email protected]> * Adding Missing Cloud Build Attributes (#3627) (#426) Signed-off-by: Modular Magician <[email protected]> * Add additional fields to Memcached Instance (#3821) (#427) Signed-off-by: Modular Magician <[email protected]> * Convert inboundServices to an enum. (#3820) (#428) Signed-off-by: Modular Magician <[email protected]> * add source_image and source_snapshot to google_compute_image (#3799) (#429) * add source_image to google_compute_image * add source_snapshot to google_compute_image * PR comment changes Signed-off-by: Modular Magician <[email protected]> * Collection fixes for release (#3831) (#430) Signed-off-by: Modular Magician <[email protected]> * Add new field filter to pubsub. (#3759) (#431) * Add new field filter to pubsub. Fixes: hashicorp/terraform-provider-google#6727 * Fixed filter name, it was improperly set. * add filter key to pubsub subscription unit test * spaces not tabs! * hardcode filter value in test * revert remove escaped quotes Co-authored-by: Tim O'Connell <[email protected]> Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Tim O'Connell <[email protected]> * Add archive class to gcs (#3867) (#432) Signed-off-by: Modular Magician <[email protected]> * Add support for gRPC healthchecks (#3825) (#433) Signed-off-by: Modular Magician <[email protected]> * Add enableMessageOrdering to Pub/Sub Subscription (#3872) (#434) Add enableMessageOrdering to Pub/Sub Subscription Signed-off-by: Modular Magician <[email protected]> * Specify possible values for arg only once (#3874) (#435) Signed-off-by: ialidzhikov <[email protected]> Signed-off-by: Modular Magician <[email protected]> * use {product}.googleapis.com endpoints (#3755) (#436) * use {product}.googleapis.com endpoints * use actual correct urls * fix zone data source test * fix network peering tests * possibly fix deleting default network Signed-off-by: Modular Magician <[email protected]> * Add vpcAccessConnector property on google_app_engine_standard_app_version terraform resource (#3789) (#437) * add vpc access connector property in standard app version resource * add Gemfile.lock and .ruby-version * modify .ruby-version * Update Gemfile.lock * Update Gemfile.lock * Update Gemfile.lock * add test for vpcAccessConnector field * change casing of test field * add comma * format app engine connector test * make vpc_access_connector an object * add vpc access connector resource to test * pass connector id output property to app engine resource instead of hardcoding connector id Signed-off-by: Modular Magician <[email protected]> * retrypolicy attribute added (#3843) (#438) * retrypolicy attribute added * test case updated Signed-off-by: Modular Magician <[email protected]> * add discovery endpoint (#3891) (#439) Signed-off-by: Modular Magician <[email protected]> * Advanced logging config options in google_compute_subnetwork (#3603) (#440) Co-authored-by: Dana Hoffman <[email protected]> Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Dana Hoffman <[email protected]> * Add Erase Windows VSS support to compute disk (#3898) (#441) Co-authored-by: Cameron Thornton <[email protected]> Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Cameron Thornton <[email protected]> * Add Snapshot location to compute snapshot (#3896) (#442) * added storage locations * add storage locations to field * tweak cmek logic * fix the decoder logic and cleanup whitespaces * remove duplicate entry Signed-off-by: Modular Magician <[email protected]> * Added missing 'all' option for protocol firewall rule (#3962) (#443) Signed-off-by: Modular Magician <[email protected]> * Revert `eraseWindowsVssSignature` field and test (#3959) (#444) Signed-off-by: Modular Magician <[email protected]> * Added support GRPC for google_compute_(region)_backend_service.protocol (#3973) (#445) Co-authored-by: Edward Sun <[email protected]> Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Edward Sun <[email protected]> * Added properties of options & artifacts on google_cloudbuild_trigger (#3944) (#446) * added options & artifacts to cloudbuild trigger * updated with minor changes and added more options in test * a test adding update behavior for multiple optional fields Co-authored-by: Edward Sun <[email protected]> Signed-off-by: Modular Magician <[email protected]> Co-authored-by: Edward Sun <[email protected]> * products/container: Add datapath provider field (#3956) (#447) Signed-off-by: Modular Magician <[email protected]> * Add SEV_CAPABLE option to google_compute_image (#3994) (#448) Signed-off-by: Modular Magician <[email protected]> * Add network peerings for inspec (#4002) (#449) Signed-off-by: Modular Magician <[email protected]> * Update docs for pubsub targets in cloud scheduler (#4008) (#450) Signed-off-by: Modular Magician <[email protected]> Co-authored-by: The Magician <[email protected]> Co-authored-by: Dana Hoffman <[email protected]> Co-authored-by: Tim O'Connell <[email protected]> Co-authored-by: Cameron Thornton <[email protected]> Co-authored-by: Edward Sun <[email protected]> Co-authored-by: Stuart Paterson <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: hashicorp/terraform-provider-google#6907
For the field, memcachedNodes.state, do we keep it as string or Enum? what happens if I set it to Enum and google adds more values?
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#3821