Partial Updates #63
Partial Updates #63
Conversation
| "projects/{project}/zones/{zone}/disks/{name}/setLabels" | ||
| ]).format(**module.params), | ||
| { | ||
| u'labels': module.params.get('labels') |
There was a problem hiding this comment.
You'll also need to send labelFingerprint, here and elsewhere.
There was a problem hiding this comment.
Do I need to? I currently do not support beta APIs on Ansible, but we list all of the labelFingerprints as beta only.
There was a problem hiding this comment.
Huh! Well, you do need to, but that probably represents an error in api.yaml.
There was a problem hiding this comment.
This doesn't seem to have been fixed.
There was a problem hiding this comment.
Do we want to fix that in this PR? I didn't know if that would clutter it up too much (we'd have changes in P/C/A/T from doing that)
Should've specified that earlier.
There was a problem hiding this comment.
Probably best to do it - otherwise you're submitting code that doesn't work. :(
modular-magician
force-pushed
the
codegen-pr-373
branch
from
b86f025 to
f44a027
Compare
| @@ -427,6 +427,8 @@ def main(): | |||
| if fetch: | |||
| if state == 'present': | |||
| if is_different(module, fetch): | |||
| update_fields(module, resource_to_request(module), | |||
| response_to_hash(module, fetch)) | |||
| fetch = update(module, self_link(module), kind) | |||
There was a problem hiding this comment.
Same deal here as the others- it should be either a partial or a full, not both
modular-magician
force-pushed
the
codegen-pr-373
branch
from
f44a027 to
d303922
Compare
| u'labels': module.params.get('labels') | ||
| } | ||
| ) | ||
| if response.get('sizeGb') != request.get('sizeGb'): |
There was a problem hiding this comment.
Someday, you're going to want to inject a "not quite just literal comparisons only" bit here - a canonicalizer, we used to call them in Maps. Don't have to do it today.
There was a problem hiding this comment.
Good call! I'm going to make a issue for this.
| @@ -236,6 +236,12 @@ | |||
| - Labels to apply to this VpnTunnel. | |||
| returned: success | |||
| type: dict | |||
| label_fingerprint: | |||
There was a problem hiding this comment.
You might find this upsetting, but unfortunately networking resources only accept labels via SetLabels calls - they do not work on create.
|
I updated this with VpnTunnel. Not sure what you consider a networking resource. |
modular-magician
force-pushed
the
codegen-pr-373
branch
from
d303922 to
1298b1a
Compare
| sizegb_update(module, request, response) | ||
|
|
||
|
|
||
| def labelfingerprint_update(module, request, response): |
There was a problem hiding this comment.
It would help readability for this to be label_fingerprint_update.
There was a problem hiding this comment.
Good call. Fixed! Running through the magician now.
modular-magician
force-pushed
the
codegen-pr-373
branch
from
1298b1a to
d5cfd99
Compare
* add locks * rename the module * add test * add test * address comments * add quote * can list child scope lock * minor docs tweaks * Add files via upload (#62) * change '\r\n' to '\n' (#63) * Small changes, just to trigger CI verify. * trigger CI verify * remove 's' * Update according by comments * change small for trigger CI check
/cc @rambleraptor