Skip to content
This repository has been archived by the owner on Nov 14, 2024. It is now read-only.

gcp_storage_object: various bug fixes #328

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

willthames
Copy link

SUMMARY
  • Handle binary file downloads correctly
  • Handle binary file uploads correctly
  • Ensure that changed is correct if no changes are required
  • Fix downloads for object keys containing slashes

Signed-off-by: Will Thames [email protected]

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

gcp_storage_object

ADDITIONAL INFORMATION

There really should be a test suite for this module

* Handle binary file downloads correctly
* Handle binary file uploads correctly
* Ensure that changed is correct if no changes are required
* Fix downloads for object keys containing slashes

Signed-off-by: Will Thames <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant