Ansible: falses being lost in network requests (#141)

lib/ansible/modules/cloud/google/gcp_compute_address.py

@@ -282,7 +282,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_backend_bucket.py

@@ -225,7 +225,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_backend_service.py

@@ -753,7 +753,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_disk.py

@@ -515,7 +515,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_firewall.py

@@ -524,7 +524,7 @@ def resource_to_request(module):
     request = encode_request(request, module)
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_forwarding_rule.py

@@ -512,7 +512,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_global_address.py

@@ -233,7 +233,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_global_forwarding_rule.py

@@ -507,7 +507,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_health_check.py

@@ -633,7 +633,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_http_health_check.py

@@ -287,7 +287,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_https_health_check.py

@@ -284,7 +284,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_image.py

@@ -528,7 +528,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_instance.py

@@ -1046,7 +1046,7 @@ def resource_to_request(module):
     request = encode_request(request, module)
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_instance_group.py

@@ -310,7 +310,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_instance_group_manager.py

@@ -407,7 +407,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_instance_template.py

@@ -990,7 +990,7 @@ def resource_to_request(module):
     request = encode_request(request, module)
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_interconnect_attachment.py

@@ -261,7 +261,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_network.py

@@ -279,7 +279,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_region_disk.py

@@ -455,7 +455,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_route.py

@@ -326,7 +326,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_router.py

@@ -330,7 +330,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_ssl_certificate.py

@@ -234,7 +234,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_ssl_policy.py

@@ -272,7 +272,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_subnetwork.py

@@ -399,7 +399,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_target_http_proxy.py

@@ -267,7 +267,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_target_https_proxy.py

@@ -395,7 +395,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_target_pool.py

@@ -321,7 +321,7 @@ def resource_to_request(module):
     request = encode_request(request, module)
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_target_ssl_proxy.py

@@ -380,7 +380,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_target_tcp_proxy.py

@@ -292,7 +292,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_target_vpn_gateway.py

@@ -238,7 +238,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_url_map.py

@@ -454,7 +454,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_compute_vpn_tunnel.py

@@ -374,7 +374,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_container_cluster.py

@@ -699,7 +699,7 @@ def resource_to_request(module):
     request = encode_request(request, module)
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_container_node_pool.py

@@ -526,7 +526,7 @@ def resource_to_request(module):
     request = encode_request(request, module)
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_dns_managed_zone.py

@@ -243,7 +243,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_dns_resource_record_set.py

@@ -243,7 +243,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_iam_service_account.py

@@ -179,7 +179,7 @@ def resource_to_request(module):
     request = encode_request(request, module)
     return_vals = {}
     for k, v in request.items():
-        if v:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_pubsub_subscription.py

@@ -265,7 +265,7 @@ def resource_to_request(module):
     request = encode_request(request, module)
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_pubsub_topic.py

@@ -146,7 +146,7 @@ def resource_to_request(module):
     request = encode_request(request, module)
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_resourcemanager_project.py

@@ -244,7 +244,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_spanner_database.py

@@ -201,7 +201,7 @@ def resource_to_request(module):
     request = encode_request(request, module)
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_spanner_instance.py

@@ -238,7 +238,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_sql_database.py

@@ -206,7 +206,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals

lib/ansible/modules/cloud/google/gcp_sql_instance.py

@@ -674,7 +674,7 @@ def resource_to_request(module):
     }
     return_vals = {}
     for k, v in request.items():
-        if v or v is False:
+        if v is not None:
             return_vals[k] = v
 
     return return_vals