Fix infinite onerror loop in avatar image loader #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avatar images have an onerror attribute to set their image to a generic avatar image if they fail to load from discord. However, in situations where the network fails or the discord CDN is unavailable for some reason (adblockers), this will throw an error as well. In browsers other than chrome, this will trigger the on-error handler again, infinitely looping requests as fast as possible. We set the onerror handler to null before making the new request to get around this and ensure if the fallback fails to load we don't make further requests. Signed-off-by: Bast <[email protected]>
|
Fixes #20 |
ChrisLovering
added a commit
to python-discord/logviewer
that referenced
this pull request
Aug 12, 2024
This is pulled directly from modmail-dev#82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avatar images have an onerror attribute to set their image to a generic avatar image if they fail to load from discord. However, in situations where the network fails or the discord CDN is unavailable for some reason (adblockers), this will throw an error as well.
In browsers other than chrome, this will trigger the on-error handler again, infinitely looping requests as fast as possible.
We set the onerror handler to null before making the new request to get around this and ensure if the fallback fails to load we don't make further requests.