Fix breaking modmail internal thread cache #3028
Merged
+30
−28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this PR:
File
thread.py
:None
in method 'find'.This possibly could prevent the bot from creating multiple threads when the user repetitively sends messages in DM on confirm thread creation.
await thread.close()
instead ofbot.loop.create_task()
to make sure the thread for the recipient is completely removed from cache (if any) before creating another one.bot.loop.create_task()
when sending "Cancelled" embed to recipient if the thread is cancelled on confirm thread creation.Resolves #3022