Add msglink command to get DM message URLs. #2964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2963
As this addition was quite small and relatively easy to implement, and that the Issue I created was marked as High Priority, I figured I'd try sending in a PR directly.
I decided that the command name of
msglinkis probably more preferable to the originally proposedjumplinkas the term Message Link is used directly in the context menu option so may be most familiar and clear in purpose for general users.For the genesis info embed change, I was unsure if there'd ever be a situation where the dm_channel does not exist so as a just-in-case, accounted for it.
Cheers.