Move Cortex-M specifics from :platform:core into :platform:cortex-m #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves STM32 specific code from the `:platform:cortex-m` module into the `:platform:core` module including: - linkerscript selection - memory region pruning - pre-startup code
salkinium
force-pushed
the
feature/core-split
branch
from
dcdfe66
to
dee5ea2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most code in
:platform:coreis actually Cortex-M specific, and is thus moved into the common:platform:cortex-mmodule and can be reused for other vendors.The only STM32 specific things are the RCC calls at the very beginning of the
Reset_Handler, which were encapsulated into__modm_initialize_platform()and of course the linkerscript templates. These were already split into a common file containing only Cortex-M specifics which were then arranged and specialized via Jinja2 macro calls in the STM32 specific templates.Finally, the linkerscript additions were implemented using Collectors, so that more than one linkerscript addition can be done and these internal details are not exposed to the user via
lbuild discover.Unfortunately this is a breaking change, since all option keys starting with
:platform:coremust be refactored to start with:platform:cortex-mnow. This is unfortunate, but well… this is modm and we break stuff.